Skip to content

added missing KOL id to EDR_stations#131

Open
feherszabolcs wants to merge 2 commits intosimrail:mainfrom
feherszabolcs:main
Open

added missing KOL id to EDR_stations#131
feherszabolcs wants to merge 2 commits intosimrail:mainfrom
feherszabolcs:main

Conversation

@feherszabolcs
Copy link

@feherszabolcs feherszabolcs commented Mar 21, 2026

Fixed a bug when clicking Koluszki station on the map redirected the user to .../station/KO ( which is Katowice's EDR page).

Summary by CodeRabbit

  • New Features

    • Added a new station "Koluszki" (code KOL) to the map data so it appears in station listings and on maps.
  • Chores

    • Standardized JSON formatting in data files for consistency.

@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b09eca51-de46-4d0e-9aa6-93093898ee2b

📥 Commits

Reviewing files that changed from the base of the PR and between 7e7fd69 and 85dc9f5.

📒 Files selected for processing (1)
  • packages/map/components/EDR_station.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/map/components/EDR_station.json

📝 Walkthrough

Walkthrough

Added a new station entry with code KOL to the EDR station JSON (id: "KOL", srName: "Koluszki"). No other entries were modified.

Changes

Cohort / File(s) Summary
EDR station data
packages/map/components/EDR_station.json
Inserted a new top-level station object for KOL (id: "KOL", srName: "Koluszki"). No other data or keys were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped to the map with a jubilant grin,
I placed little KOL where new journeys begin,
One tiny entry, precise and so quick,
Koluszki arrives — a fresh little tick!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding the missing KOL station id to the EDR_stations file to fix a redirection bug.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@atxw
Copy link

atxw commented Mar 25, 2026

Hello and thank you for your contribution 👋

note: i'm not maintainer here, simply commenting over automated review since i briefly reviewed it.

Contrary to what is stated in fancy generated walkthrough:

  • data is correctly updated and link to Koluszki station in edr works as expected 👍
  • i don't know if the json formatting update is voluntary or not but it's very likely to trigger linter warnings given its config in this repo (run pnpm biome check at root to run it and check results) --> digging in history shows previous style fix performing the exact opposite operation at commit e4fefd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants