docs(network-ports): de-duplicate rows and drop firewall ports#168
Merged
Conversation
The shared network port table (included in install-cp and k8s-storage-plane) listed each control<->storage flow twice — one row for the egress end and one for the ingress end of the same port. Collapse those pairs into a single row per service (Direction 'ingress, egress', Hosts 'storage, control'), matching the style already used by the nvmf-internal and Monitoring rows. Also remove the spdk-firewall-proxy rows (50001-50065) and their deprecation footnote: port blocking is now done in-band via the SPDK nvmf_port_block RPC, so no separate firewall-proxy port range needs to be opened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the shared network port table (
snippets/network-port-table.md, included in install-cp and k8s-storage-plane).Two problems
spdk-http-proxyandControl plane RPC). Collapsed each pair into a single row (Directioningress, egress, Hostsstorage, control), matching the style already used by thenvmf (internal)andMonitoring Stackrows.spdk-firewall-proxyrows (50001-50065) and the deprecation footnote. Port blocking is now done in-band via the SPDKnvmf_port_blockRPC (port_block.set_port), so no separate firewall-proxy port range needs to be opened.🤖 Generated with Claude Code