Skip to content

Add explicit check for negative overflows in IntegerValue class - #100

Merged
tvdijen merged 4 commits into
simplesamlphp:masterfrom
baszoetekouw:fix/int-overflow-check
Aug 19, 2026
Merged

Add explicit check for negative overflows in IntegerValue class#100
tvdijen merged 4 commits into
simplesamlphp:masterfrom
baszoetekouw:fix/int-overflow-check

Conversation

@baszoetekouw

Copy link
Copy Markdown
Contributor

in addition, add tests for IntegerValue::fromInteger to bring coverage for this class to 100%

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (c50b33d) to head (4f863d1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     91.04%   91.25%   +0.21%     
- Complexity      969      971       +2     
============================================
  Files           218      218              
  Lines          3495     3499       +4     
============================================
+ Hits           3182     3193      +11     
+ Misses          313      306       -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvdijen
tvdijen merged commit cc3ad6b into simplesamlphp:master Aug 19, 2026
15 of 16 checks passed
@tvdijen

tvdijen commented Aug 19, 2026

Copy link
Copy Markdown
Member

Thanks Bas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants