Add a Redis store - #57
Merged
Merged
Conversation
Member
|
Tagged v1.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've often wondered why the consent module doesn't have a Redis-based store. It's an obvious choice if you already use Redis-based sessions and have set it up for high availability.
I was writing some other Redis code and needed a challenge, so I thought I'd give it a go.
Full disclosure: what's here was produced with assistance from GitHub Copilot for the heavy lifting. But AI-generated code has all been manually reviewed (and changed!).
I've tried to keep it consistent with the way consent:Database works, but added inheritance of config from the global
store.redis.*options in config.php. That makes more sense here because of how Redis itself works -- IMHO you're unlikely to have a second instance dedicated to this (although you might use a separate database slot).