Preserve settings until the plugin is uninstalled - #45
Merged
adriaandotcom merged 2 commits intoSep 15, 2026
Merged
adriaandotcom merged 2 commits into
adriaandotcom merged 2 commits into
Conversation
adriaandotcom
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deactivation now preserves the plugin's configuration. Cleanup runs only through WordPress's guarded
uninstall.phpentry point when the plugin is deleted, including per-site options across a multisite network in batches of 100.Fixes #36.
Validation: a WordPress regression test fails on the original deactivation hook, then passes with the fix. It checks deactivation, the activation callback, actual
uninstall_plugin()cleanup, and preservation of unrelated options using an isolated temporary options table. PHP syntax and diff checks pass. The automated integration check runs on a single-site WordPress installation.Combined validation: all six proposed fixes were applied to a local integration branch; all 23 browser and WordPress regression tests, the asset build, PHP syntax checks and diff checks passed. GitHub workflows currently report
action_requiredfor these fork pull requests.