Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the
insert-filescommand's encoding option to the documented UTF-8 default. Disk files and standard input now use the same default. An explicit--encodingstill controls decoding.Fixes #952.
The regression runs the CLI with the POSIX
Clocale and Python's automatic UTF-8 mode disabled, then checks the text stored in SQLite. It fails before the fix.Local validation on macOS and Python 3.12.13: the 10
insert-filestests passed. The full suite had 1,498 passing tests and 16 skips. Black and Flake8 passed for both changed files, and mypy passed for the package. The new locale regression is skipped on Windows because it requires the POSIXClocale.Codex assisted with diagnosis, the change, and verification.
📚 Documentation preview 📚: https://sqlite-utils--953.org.readthedocs.build/en/953/