Handle collided resonators in uMUX crosstalk#1287
Merged
Conversation
tpsatt
force-pushed
the
collided_resonators
branch
from
0dc213b to
230a1ca
Compare
tpsatt
force-pushed
the
collided_resonators
branch
from
58de95c to
d6926c4
Compare
keskitalo
approved these changes
Apr 8, 2026
Member
keskitalo
left a comment
keskitalo
left a comment
There was a problem hiding this comment.
Critical fixes and readability improvements. Great work!
| avg_f = (freq1 + freq2) / 2 | ||
| chi = alpha * np.power(avg_f, 4) * np.power(df, -2) * 1e12 | ||
| if chi > 1: | ||
| # Check for anomalously high chi in absense of resonator collision |
Member
There was a problem hiding this comment.
This seems like a hack. What is causing anomalously high chi without collision?
Contributor
Author
There was a problem hiding this comment.
The print statements are a legacy from the original implementation. I can't think of a reason the chi would be anomalously high without a collision other than anomalously high frequencies (i.e. input in the wrong units) which we haven't seen before but could be worth checking against
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports handling of collided resonators (very small measured frequency spacing in UFM screening at Princeton -- makes chi get very large) by not adding crosstalk to these TODs, and flagging detectors.