Open
Conversation
* fix tests failing due to not waiting for sim to finish * move wait to tear down
… poised-to-bloom
kdovtdc
reviewed
Nov 1, 2024
Collaborator
There was a problem hiding this comment.
comment on lc implementation only
ChatGPT gave some interesting ideas
| modifier.Register(poised, modifier.Config{}) | ||
|
|
||
| modifier.Register(poisedCritDmg, modifier.Config{ | ||
| Stacking: modifier.Unique, |
Collaborator
There was a problem hiding this comment.
requires StatusType: model.StatusType_STATUS_BUFF,
nit: Stacking is Unique by default so can be removed
Collaborator
There was a problem hiding this comment.
can also use CanDispel: true, now
|
|
||
| func Create(engine engine.Engine, owner key.TargetID, lc info.LightCone) { | ||
| atkAmt := 0.12 + 0.04*float64(lc.Imposition) | ||
| critDmgAmt := 0.12 + 0.04*float64(lc.Imposition) |
Collaborator
There was a problem hiding this comment.
nit: can use the same variable for both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the lightcone Poised To Bloom and unit tests for it, which included creating new testchars and new testcones to be able to test the functionality of the lc.
Main potential concerns are:
testcharBronya has Dance Dance Dance as her default LC, which might cause potential test annoyances in the future. This is a minor issue if one at all; any suggestions on better LCs to use would be appreciated.