Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to replace conditional byte stores with unconditional selection, allowing GCC to vectorize the substitution loop. Faster altchars is quite useful for things like older IMAP servers and boto, since cloudfront requires two altchars - https://github.com/boto/botocore/blob/develop/botocore/signers.py#L491. I reliably see a 10x improvement.
64 KiB custom encoding: 78.43 us to 6.15 us (12.8x faster) on Ryzen 5800X, GCC 16.2.1, -O3.
Disassembly excerpts:
Before: scalar load and per-byte branches.
After: 16-byte loads, SIMD comparisons and masked selection.