Add HTJ2K plugin - #405
Merged
Merged
Conversation
payno
commented
Aug 24, 2026
Comment on lines
+45
to
+54
| @@ -50,6 +51,7 @@ | |||
| FciDecomp, | |||
| Sperr, | |||
| Zfp, | |||
| Zhtj2k, | |||
Member
Author
There was a problem hiding this comment.
I was not really sure about the names to be used. Please feel free to propose something better.
| ZFP_ID = 32013 | ||
| """ZFP filter ID""" | ||
|
|
||
| ZHT_JP2K_ID = 32033 |
Member
Author
There was a problem hiding this comment.
From last information I had. I hope this is up to date.
| return cls(minbits=minbits, maxbits=maxbits, maxprec=maxprec, minexp=minexp) | ||
|
|
||
|
|
||
| class Zhtj2k(FilterBase): |
Member
Author
There was a problem hiding this comment.
As not parameter can be provided at the moment I think there is no much more to do. Maybe a better docstring ?
| h5z_htj2k_dir = "lib/h5z-htj2k" | ||
| openjph_include_dir = f"{h5z_htj2k_dir}/vendored/OpenJPH/src/core/openjph" | ||
|
|
||
| extra_compile_args = ["-O3", "-std=c++17"] |
Member
Author
There was a problem hiding this comment.
t20100
force-pushed
the
add_jp2k_ht
branch
2 times, most recently
from
August 25, 2026 15:24
62a2be9 to
888e3f6
Compare
Member
|
Changed a few things:
Still need to fix a build issue on macos: |
git-subtree-dir: lib/h5z-htj2k git-subtree-split: ba280c2aa849de06742ee5f5f43ad695865ccf8c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to add the 'ht-jp2k' plugin.