Refactor Serval.DataFiles to vertical slices#943
Conversation
b5397ce to
1e1c200
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
- Coverage 66.73% 66.69% -0.04%
==========================================
Files 372 381 +9
Lines 21687 21736 +49
Branches 2771 2773 +2
==========================================
+ Hits 14472 14497 +25
- Misses 6179 6203 +24
Partials 1036 1036 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 partially reviewed 43 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit).
src/Serval/src/Serval.ApiServer/Startup.cs line 157 at r1 (raw file):
if (Environment.IsDevelopment()) { services
This isn't related, is it? Is this just because we never really followed up on using OpenTelemetry?
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).
src/Serval/src/Serval.ApiServer/Startup.cs line 157 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
This isn't related, is it? Is this just because we never really followed up on using OpenTelemetry?
Yeah, I was sick of seeing all of the noise of the trace messages on the commandline. We have no plans to do anything with tracing, so I just removed it.
1e1c200 to
f34432d
Compare
This change is