Conversation
Previously updated the NumberingStyle get method in SenseOptionsView, so that it returns null when no numbering style is selected. This avoids an issue where sense numbering style gets treated as empty when reversal number style is an empty string. But this only applies to the dictionary configuration dialog preview. Updating the NumberingStyle get method in DictionaryNodeOptions to fix the issue for the dictionary and reversal displays. Change-Id: Id8442bba1e72049272e67d5fc5424f8ef42fe3c7
NUnit Tests 1 files ±0 1 suites ±0 11m 34s ⏱️ +57s For more details on these failures, see this check. Results for commit 1c25b82. ± Comparison against base commit 272325a. ♻️ This comment has been updated with latest results. |
Instead of changing behavior of NumberingStyle get method, create NonEmptyNumberingStyle property whose get returns null if empty. Change-Id: Ica58deff94eedcda8549fb9ae971151ea16b79e8
Change-Id: I5eac83e66fc4b9f8d684ed7e0fb1693a1e770bc0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously updated the NumberingStyle get method in SenseOptionsView, so that it returns null when no numbering style is selected. This avoids an issue where sense numbering style gets treated as empty when reversal number style is an empty string.
But this only applies to the dictionary configuration dialog preview.
Updating the NumberingStyle get method in DictionaryNodeOptions to fix the issue for the dictionary and reversal displays.
This change is