Skip to content

Reuse integration test project data in RootSite tests#891

Open
johnml1135 wants to merge 2 commits into
mainfrom
no_more_dummy_projects
Open

Reuse integration test project data in RootSite tests#891
johnml1135 wants to merge 2 commits into
mainfrom
no_more_dummy_projects

Conversation

@johnml1135
Copy link
Copy Markdown
Contributor

@johnml1135 johnml1135 commented May 18, 2026

Summary

  • reuse a fixed integration_test_data project name in RealDataTestsBase instead of generating a new RealDataTest_<guid> project for each run
  • delete the actual created project directory before setup and after teardown so repeated test runs do not accumulate dummy projects
  • keep the change scoped to the RootSite real-data test base used by the render verification/timing fixtures

Validation

  • ./test.ps1 -TestProject RootSiteTests -TestFilter "FullyQualifiedName~RenderVerifyTests" -NoBuild
  • CI: Whitespace check
  • CI: Commit messages

This change is Reviewable

Copilot AI review requested due to automatic review settings May 18, 2026 21:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Reworks RootSite real-data test setup/teardown to reuse a fixed integration test project name and clean up the created project directory between runs, avoiding accumulation of dummy projects.

Changes:

  • Use a constant project name (integration_test_data) instead of a per-run GUID project name.
  • Delete the project directory before setup and after teardown.
  • Track the created project directory from CreateNewLangProj and reuse it for cleanup.

Comment thread Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs
Comment thread Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs Outdated
Comment thread Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs
Comment thread Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs Outdated
Comment thread Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 5s ⏱️ + 1m 49s
4 205 tests ±0  4 134 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 214 runs  ±0  4 143 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 9348219. ± Comparison against base commit ad3b499.

♻️ This comment has been updated with latest results.

@johnml1135 johnml1135 force-pushed the no_more_dummy_projects branch from c547de1 to 9348219 Compare May 19, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants