LT-22351: Offer Graphite features in Styles and refresh after font changes - #1165
Open
jasonleenaylor wants to merge 2 commits into
Open
jasonleenaylor wants to merge 2 commits into
jasonleenaylor wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
+ Coverage 39.01% 39.02% +0.01%
==========================================
Files 1520 1522 +2
Lines 352805 353018 +213
Branches 40692 40744 +52
==========================================
+ Hits 137632 137773 +141
- Misses 185879 185927 +48
- Partials 29294 29318 +24
🚀 New features to boost your workflow:
|
Pass the selected writing system's Graphite setting to the Font Features button before the font name is applied, so a Graphite-enabled writing system lists Graphite features instead of the OpenType list. The default row covers every writing system, so it keeps the OpenType preference. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Raise the writing system model's update event when the default font, its font features, the Graphite setting, the text direction, or the numbering system changes, not only when the abbreviation or id changes. The Lexicon Edit dictionary preview keeps the page it generated earlier until a refresh, so a feature chosen in Writing System Properties never reached it. Raise the event once, after the save's unit of work closes, and skip it when the list update already refreshes. Also stop the font tab writing the Graphite flag onto a writing system just for displaying it, which marked an untouched writing system changed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
jasonleenaylor
force-pushed
the
LT-22351-style-dialog-graphite-features
branch
from
September 29, 2026 15:25
8c56d85 to
a145300
Compare
jasonleenaylor
marked this pull request as ready for review
September 29, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two problems that reopened LT-22351, testing with Charis SIL 5.0.
Offer Graphite features in the Styles dialog font tab. The Styles dialog now passes the selected writing system's Graphite setting to the Font Features button before it applies the font name. A Graphite-enabled writing system now gets the Graphite feature list instead of the OpenType one. The default row covers every writing system, so it keeps the OpenType preference.
Refresh views when a writing system's rendering settings change. The writing system model now raises its update event when the default font, its font features, the Graphite setting, the text direction, or the numbering system changes. Before, it did this only when the abbreviation or id changed. The event is raised once, after the save's unit of work has closed, and not at all when the list-changed event will refresh anyway. Font features are compared after normalizing, and the font tab no longer writes the Graphite flag onto a writing system just for displaying it, so an untouched writing system no longer counts as changed.
Why it failed
🤖 Generated with Claude Code
This change is