LT-22725: Show abbreviation for user-defined natural classes - #1158
Merged
Merged
Conversation
In the phonological rule formula, a feature-based natural class was always drawn as its list of features, even when the user had built and named the class. Only classes abbreviated "C" or "V" showed their abbreviation, and only when they had a single feature. The rule view now draws a user-defined feature-based natural class as its abbreviation in brackets, whatever its number of features. An empty abbreviation displays as "***". Classes created automatically when features are inserted directly into a rule still display their features. A class counts as user-defined when it has a name that is not auto-generated. That check now takes the natural class as an argument, so the view can apply it to each class it draws rather than to the current selection. Line count and width use the same check, so the cell is sized to the abbreviation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Change-Id: Iebd499482136c21f722e1ed102920caa69a71e9f
Comment hygiene (advisory)No comment-style violations in the lines this branch adds since |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
- Coverage 38.95% 38.94% -0.01%
==========================================
Files 1520 1520
Lines 352476 352528 +52
Branches 40636 40648 +12
==========================================
- Hits 137296 137282 -14
- Misses 185899 185952 +53
- Partials 29281 29294 +13
🚀 New features to boost your workflow:
|
Shorten comment lines to align with comment hygiene. Register the display dependencies on NC's name and abbreviation for displaying phonological & affix process rules. This ensures if names or abbreviations are updated, the display widths are recalculated so new names/abbreviations fit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Change-Id: I97759674dbc305d54a0f75a8d21cbca321e1ed58
Contributor
Author
|
One ignored note from Devin's review:
BestAnalysisAlternative already uses |
aror92
marked this pull request as ready for review
September 24, 2026 19:35
thejambi
approved these changes
Sep 25, 2026
thejambi
left a comment
thejambi
left a comment
Contributor
There was a problem hiding this comment.
@thejambi reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on aror92).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the phonological rule formula, a feature-based natural class was always drawn as its list of features, even when the user had built and named the class. Only classes abbreviated "C" or "V" showed their abbreviation, and only when they had a single feature.
The rule view now draws a user-defined feature-based natural class as its abbreviation in brackets, whatever its number of features. An empty abbreviation displays as "***". Classes created automatically when features are inserted directly into a rule still display their features.
A class counts as user-defined when it has a name that is not auto-generated. That check now takes the natural class as an argument, so the view can apply it to each class it draws rather than to the current selection. Line count and width use the same check, so the cell is sized to the abbreviation.
This change is