fix Click-to-Call examples#389
Open
hey-august wants to merge 2 commits into
Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per docs-legacy#806, the Click-to-Call
#callcontainer (thecallParentSelectortarget) needs an explicit CSSheight. Without one, the widget collapses to0px, so the button works and the call connects with audio, but the call interface renders as a blank white area.Added a
Warningcallout in the "Prepare your website" step to explain this, and note that there is currently no built-inheight/min-heightfallback (tracked in cloud-product#17696). Also added a troubleshooting bullet.The HTML examples had also been mistakenly targeted during the migration to Fern when we removed HTML elements in bulk, so I fixed that as well.
Type of Change
Related Issues
docs-legacy#806
Testing
Checklist