Skip to content

python(fix): fixing time type #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtoth-dev merged 1 commit into from
Jul 20, 2026
Merged

python(fix): fixing time type #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/lib/sift_client/_internal/low_level_wrappers/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

from sift_client._internal.disk_cache import DiskCache
from sift_client._internal.low_level_wrappers.base import LowLevelClientBase
from sift_client._internal.time import to_timestamp_nanos
from sift_client._internal.time import to_timestamp_nanos, to_timestamp_pb
from sift_client._internal.util.progress import alive_bar
from sift_client.sift_types.channel import Channel, ChannelDataType
from sift_client.transport import WithGrpcClient
Expand Down Expand Up @@ -580,8 +580,8 @@ async def _get_data_impl(
request_kwargs: dict[str, Any] = {
"queries": queries,
"sample_ms": 0,
"start_time": start_time,
"end_time": end_time,
"start_time": to_timestamp_pb(start_time) if start_time else None,
Comment thread
alexluck-sift marked this conversation as resolved.
"end_time": to_timestamp_pb(end_time),
"page_size": page_size,
"page_token": page_token,
}
Expand Down
Loading