Skip to content

python(feat): add public sift.canvas.v1 proto package#683

Merged
ian-sift merged 4 commits into
mainfrom
eng-12818-canvas-cell-execution-status-proto
Jul 17, 2026
Merged

python(feat): add public sift.canvas.v1 proto package#683
ian-sift merged 4 commits into
mainfrom
eng-12818-canvas-cell-execution-status-proto

Conversation

@ian-sift

@ian-sift ian-sift commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • New protos/sift/canvas/v1/canvas.proto hosting the CanvasCellExecutionStatus enum.

Test plan

  • scripts/gen.sh python regenerates cleanly.
  • python -c "from sift.canvas.v1 import canvas_pb2; print(list(canvas_pb2.CanvasCellExecutionStatus.items()))" prints all 10 enum values with their stable integer identifiers.
  • uv lock refreshes without drift.
  • CI passes.

Added ``protos/sift/canvas/v1/canvas.proto`` hosting the
``CanvasCellExecutionStatus`` enum, which previously only lived in
the internal ``sift_internal.canvas.v1`` package. Public callers
(e.g. ``sift.reports.v1``) can now reference the status enum without
pulling ``sift_internal`` into their type graph. Wire values are
unchanged across the public / internal split.

Regenerated the Python bindings via ``scripts/gen.sh python`` and
bumped ``sift_stack_py`` 0.19.0 -> 0.20.0.
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Python docs preview: https://sift-stack.github.io/sift/python/pr-683/

Deployed from aedcb17. The link may take up to a minute to become live as GitHub Pages propagates.

@ian-sift
ian-sift requested a review from alexluck-sift July 14, 2026 18:03
Comment thread python/pyproject.toml Outdated
Comment thread protos/sift/canvas/v1/canvas.proto
Comment thread python/CHANGELOG.md Outdated
@ian-sift
ian-sift requested a review from alexluck-sift July 14, 2026 18:28
@ian-sift
ian-sift enabled auto-merge (squash) July 14, 2026 18:35
@ian-sift
ian-sift merged commit 112ae07 into main Jul 17, 2026
26 checks passed
@ian-sift
ian-sift deleted the eng-12818-canvas-cell-execution-status-proto branch July 17, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants