Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc329d2ea3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| guard let tabGroup = window.tabGroup else { return } | ||
| guard let targetWindow = tabGroup.windows.first(where: { $0.windowNumber == windowNumber }) else { return } |
There was a problem hiding this comment.
Close tab when no native tab group exists
The new sidebar Close Tab action becomes a no-op when the current window is not in an AppKit tab group (for example, a single window/tab setup), because closeNativeTab returns early on window.tabGroup == nil instead of delegating to closeTab(_:). This means users can see the context-menu action but it silently does nothing in that common state.
Useful? React with 👍 / 👎.
Close Tabto sidebar tab rows and route it to the exact native tab window behind the rowRemove Worktree…andReveal in Finderactions used by regular worktree rowsVerified with
zig build test.