Skip to content

Rebuild the Worker settings tab - #64

Merged
nicosuave merged 2 commits into
mainfrom
claude/settings-page-ux-4b12a2
Nov 6, 2026
Merged

nicosuave merged 2 commits into
mainfrom
claude/settings-page-ux-4b12a2

Conversation

@nicosuave

Copy link
Copy Markdown
Member

The Worker Settings tab had a large dead gap, three competing left edges, and Secrets, Link and Library rendered below the form's Save bar, so it was unclear what that button saved.

Changes

  • Render the Settings panel outside the source form. Secrets and Link have their own forms and cannot nest, which is why they ended up below it. Enter in a Configuration field still deploys.
  • Lay the tab out as one aligned column: Configuration, Secrets, Sharing, Library. "Save and deploy Worker" now closes the Configuration section only.
  • Merge required secret names into the secret values list. Declared secrets with no value show "Needs a value" with a "Set value" action; saved secrets the manifest does not declare show "Not passed to the Worker". This matches the controller, which fails a deploy on a missing declared secret and only passes declared secrets to env.
  • State that saving a secret redeploys the current revision, and what a library move keeps.
  • Rename the "Link" section to "Sharing", since it sat directly above a field labeled "Link".

Shared components

  • SecretControls: the "Secret names loaded" message is gone and "Remove secret" only renders for a saved secret. This also applies to the script and artifact settings pages.
  • StringList: rows are now full width, which also changes the Triggers tab.
  • LinkSettings: the "No link yet" message now takes its own line.

Verification

tsc --noEmit, bun run test:mcp-ui (51 pass) and the src/gallery unit tests pass. e2e/gallery-native-apps.test.ts now covers the secret states, the "Set value" flow and section order. The page was checked in light and dark themes at desktop and phone widths against stubbed data, not a deployed environment.

Moving a Worker between libraries still has no confirmation step. That is unchanged here.

Render Settings outside the source form so Secrets, Sharing and Library
can sit inside the panel instead of below its Save bar, and give each
section its own clear save. Show which declared secrets need a value and
which saved values never reach the Worker.
…ux-4b12a2

# Conflicts:
#	e2e/gallery-native-apps.test.ts
#	src/gallery/native-apps.tsx
@nicosuave
nicosuave merged commit 3982143 into main Nov 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant