Repository navigation
Rebuild the Worker settings tab - #64
Merged
Merged
Conversation
Render Settings outside the source form so Secrets, Sharing and Library can sit inside the panel instead of below its Save bar, and give each section its own clear save. Show which declared secrets need a value and which saved values never reach the Worker.
…ux-4b12a2 # Conflicts: # e2e/gallery-native-apps.test.ts # src/gallery/native-apps.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Worker Settings tab had a large dead gap, three competing left edges, and Secrets, Link and Library rendered below the form's Save bar, so it was unclear what that button saved.
Changes
env.Shared components
SecretControls: the "Secret names loaded" message is gone and "Remove secret" only renders for a saved secret. This also applies to the script and artifact settings pages.StringList: rows are now full width, which also changes the Triggers tab.LinkSettings: the "No link yet" message now takes its own line.Verification
tsc --noEmit,bun run test:mcp-ui(51 pass) and thesrc/galleryunit tests pass.e2e/gallery-native-apps.test.tsnow covers the secret states, the "Set value" flow and section order. The page was checked in light and dark themes at desktop and phone widths against stubbed data, not a deployed environment.Moving a Worker between libraries still has no confirmation step. That is unchanged here.