feat: add support for multiple cloudformation stacks (Add apiId)#647
Draft
plezan wants to merge 37 commits intosid88in:masterfrom
Draft
feat: add support for multiple cloudformation stacks (Add apiId)#647plezan wants to merge 37 commits intosid88in:masterfrom
plezan wants to merge 37 commits intosid88in:masterfrom
Conversation
Merge branch 'master'
fix: support serverless >= 4.0.23 (sid88in#632)
fix: Deployment using serverless-compose
Author
|
Also tested without any issue with serverless-appsync-simulator using serverless v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #597, updated to be mergeable on master.
I tried to follow @bboure review comments on the original PR.
The goal of this PR is to add support for splited appsync config across multiple services. This is required to bypass the 500 resources limit on cloud formation stacks.
Since the support for Serverless v3 will be dropped at the end of the year, I mainly focused on making those changes compatipble with sls v4.
Main changes
apiIdto appsync config to allow adding resources to an existing appsync apiWhat else changed in the project ?
To be be properly compatible with serverless v4 and serverless compose i needed to make a few other changes :
Status
Tested with:
Not tested with:
The code and documentation still need some cleanup work.
Any feedback is welcome !