Conversation
Contributor
sstimac
commented
Aug 16, 2023
sstimac
commented
- updated some of the critical underlying packages
- as a result, download cached is now a local method instead of dependency ( collision with the old version of mkdir, and the actual package is on Ivo's private repo )
- upgrade to babel 7
- move config to src directory, so that it properly points to imports inside build dir that is compiled by babel, instead of src directory
Definitely-Not-Vlad
suggested changes
Aug 22, 2023
Contributor
Definitely-Not-Vlad
left a comment
Definitely-Not-Vlad
left a comment
There was a problem hiding this comment.
Only 1 silly request, which is the line removal, but also requesting changes as there are issues with shoutem publish that need to be resolved before this can go live.
Likely related to file upload request and changes introduced from tar replacing tar.gz.
| ); | ||
| await targz().compress(packageDir, destinationDirectory); | ||
| await tar.c({ file: destinationDirectory }, [packageDir]); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.