Repository navigation
fix: draw clip filters in the preview as the render applies them - #265
Open
dazzatronus wants to merge 1 commit into
Open
dazzatronus wants to merge 1 commit into
dazzatronus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio drew a clip with
filterset as if it were unset, so previews, share links andshotstack inspectsheets differed from the render.boost,contrast,darken,greyscale,lighten,muted,negative) share one shader that ports the render's per-pixel maths on unpremultiplied colour.ColorMatrixFiltercan't: saturation pivots on HSP brightness, so a linear matrix greys pure red to 76 where the render gives 139.bluris pixi'sBlurFilterwith edges repeated, like the render's clamped box blur. Blur strength is now set as each frame draws, so a capture, which resets the editor zoom to 1:1, blurs like the render. The zoom transition's blur read the same stale on-screen zoom and is fixed with it.Verify:
shotstack inspecta 3×3 grid of one image under each filter, againstinspectof its render at 1 s. Every tile's mean colour lands within 3 levels of the render's, and the blur radius matches (3 px at scale 0.32).Risk: the WebGPU shader compiles under a WGSL validator but hasn't drawn a frame; Studio initialises WebGL.