fix: resolve font family names with surrounding whitespace to the declared font#120
Merged
Merged
Conversation
dazzatronus
force-pushed
the
derk/eng-652-studio-delegate-parser
branch
from
529bd4e to
cae4842
Compare
dazzatronus
changed the title
dazzatronus
changed the title
dazzatronus
force-pushed
the
derk/eng-652-studio-delegate-parser
branch
from
cae4842 to
264c520
Compare
dazzatronus
changed the title
|
🎉 This PR is included in version 2.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio's
parseFontFamilynow delegates to the shared@shotstack/shotstack-canvasparser (bumped to^2.9.0), so a family name is split consistently wherever it is used.Behaviour change: a
font.familywith leading/trailing whitespace — common from CMS fields and{{merge}}variables — now resolves to the declared font instead of a fallback. Every diverging input moves toward the declared intent; none regresses.Changes
@shotstack/shotstack-canvas→^2.9.0.font-config.ts:parseFontFamilydelegates to the shared parser; keeps the{baseFontFamily, fontWeight}return shape so call sites are untouched.Validation
26-input old-vs-new equivalence (clean inputs identical; whitespace/null inputs now resolve instead of falling through);
tsc --noEmitclean; 1791 tests pass.parseFontFamilyis not part of the public API.