fix: mock builder handles traits and enums#2328
Open
Marcus Müller (M-arcus) wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the PHPUnit unit testing guide example to avoid attempting to mock PHP types that cannot/shouldn’t be mocked (traits/enums), improving the robustness of the documented sample test.
Changes:
- Introduces a
$classNamevariable with aclass-stringannotation for clarity. - Skips mocking when the discovered symbol is a trait or enum.
- Simplifies the mock builder call by passing
$classNamedirectly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+105
to
+107
| if (trait_exists($className) || enum_exists($className)) { | ||
| continue; | ||
| } |
Comment on lines
+105
to
+107
| if (trait_exists($className) || enum_exists($className)) { | ||
| continue; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test will fail as soon as Enums or Traits are introduced. This PR skips the instancing of them.
Related links
Checklist
PageRefreferences where relevant..gitbook.yamlif pages were moved, renamed, or deleted..wordlist.txt(and sorted it) if spellcheck flags new legitimate terms.Notes