Skip to content

removed namespace.yaml manifest from kustomize resources#79

Open
henzigo wants to merge 1 commit intojg/autoscalingfrom
jg/namespace
Open

removed namespace.yaml manifest from kustomize resources#79
henzigo wants to merge 1 commit intojg/autoscalingfrom
jg/namespace

Conversation

@henzigo
Copy link
Copy Markdown
Member

@henzigo henzigo commented Apr 15, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the standalone Namespace manifest from the rendered kustomize outputs and adjusts deployment/apply flow to target the project namespace explicitly, so generated manifests no longer include a Namespace object (and associated scenario fixtures are updated accordingly).

Changes:

  • Removed kubernetes/namespace.yaml and stopped including it in kustomize resources.
  • Updated deploy pipeline to apply kustomize output with kubectl apply -n ${PROJECT_NAME}.
  • Updated scenario expected manifests to no longer include a Namespace document / expected namespace.yaml file.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/scenarios/production-with-cloudflare/expected/webserver.yaml Updates expected output to remove the Namespace document from rendered YAML.
tests/scenarios/production-with-cloudflare/expected/namespace.yaml Removes the expected namespace manifest fixture.
tests/scenarios/production-with-cloudflare/expected/migrate-first-deploy.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/production-with-cloudflare/expected/migrate-first-deploy-with-demo-data.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/production-with-cloudflare/expected/migrate-continuous-deploy.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/escaping-env/expected/webserver.yaml Updates expected output to remove the Namespace document from rendered YAML.
tests/scenarios/escaping-env/expected/namespace.yaml Removes the expected namespace manifest fixture.
tests/scenarios/escaping-env/expected/migrate-first-deploy.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/escaping-env/expected/migrate-first-deploy-with-demo-data.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/escaping-env/expected/migrate-continuous-deploy.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/development-single-domain/expected/webserver.yaml Updates expected output to remove the Namespace document from rendered YAML.
tests/scenarios/development-single-domain/expected/namespace.yaml Removes the expected namespace manifest fixture.
tests/scenarios/development-single-domain/expected/migrate-first-deploy.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/development-single-domain/expected/migrate-first-deploy-with-demo-data.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/development-single-domain/expected/migrate-continuous-deploy.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/basic-production/expected/webserver.yaml Updates expected output to remove the Namespace document from rendered YAML.
tests/scenarios/basic-production/expected/namespace.yaml Removes the expected namespace manifest fixture.
tests/scenarios/basic-production/expected/migrate-first-deploy.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/basic-production/expected/migrate-first-deploy-with-demo-data.yaml Removes the Namespace document from expected rendered output.
tests/scenarios/basic-production/expected/migrate-continuous-deploy.yaml Removes the Namespace document from expected rendered output.
kubernetes/namespace.yaml Deletes the namespace manifest template.
kubernetes/kustomize/webserver/kustomization.yaml Removes namespace.yaml from kustomize resources.
kubernetes/kustomize/migrate-application/first-deploy/kustomization.yaml Removes namespace.yaml from kustomize resources.
kubernetes/kustomize/migrate-application/first-deploy-with-demo-data/kustomization.yaml Removes namespace.yaml from kustomize resources.
kubernetes/kustomize/migrate-application/continuous-deploy/kustomization.yaml Removes namespace.yaml from kustomize resources.
kubernetes/horizontalStorefrontAutoscaler.yaml Removes hardcoded namespace from HPA metadata.
kubernetes/horizontalPodAutoscaler.yaml Removes hardcoded namespace from HPA metadata.
deploy/parts/deploy.sh Applies kustomize output using kubectl apply -n ${PROJECT_NAME}.
UPGRADE.md Documents the change for v5.1.0 upgrade notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants