removed namespace.yaml manifest from kustomize resources#79
Open
henzigo wants to merge 1 commit intojg/autoscalingfrom
Open
removed namespace.yaml manifest from kustomize resources#79henzigo wants to merge 1 commit intojg/autoscalingfrom
namespace.yaml manifest from kustomize resources#79henzigo wants to merge 1 commit intojg/autoscalingfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the standalone Namespace manifest from the rendered kustomize outputs and adjusts deployment/apply flow to target the project namespace explicitly, so generated manifests no longer include a Namespace object (and associated scenario fixtures are updated accordingly).
Changes:
- Removed
kubernetes/namespace.yamland stopped including it in kustomizeresources. - Updated deploy pipeline to apply kustomize output with
kubectl apply -n ${PROJECT_NAME}. - Updated scenario expected manifests to no longer include a
Namespacedocument / expectednamespace.yamlfile.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/scenarios/production-with-cloudflare/expected/webserver.yaml | Updates expected output to remove the Namespace document from rendered YAML. |
| tests/scenarios/production-with-cloudflare/expected/namespace.yaml | Removes the expected namespace manifest fixture. |
| tests/scenarios/production-with-cloudflare/expected/migrate-first-deploy.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/production-with-cloudflare/expected/migrate-first-deploy-with-demo-data.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/production-with-cloudflare/expected/migrate-continuous-deploy.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/escaping-env/expected/webserver.yaml | Updates expected output to remove the Namespace document from rendered YAML. |
| tests/scenarios/escaping-env/expected/namespace.yaml | Removes the expected namespace manifest fixture. |
| tests/scenarios/escaping-env/expected/migrate-first-deploy.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/escaping-env/expected/migrate-first-deploy-with-demo-data.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/escaping-env/expected/migrate-continuous-deploy.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/development-single-domain/expected/webserver.yaml | Updates expected output to remove the Namespace document from rendered YAML. |
| tests/scenarios/development-single-domain/expected/namespace.yaml | Removes the expected namespace manifest fixture. |
| tests/scenarios/development-single-domain/expected/migrate-first-deploy.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/development-single-domain/expected/migrate-first-deploy-with-demo-data.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/development-single-domain/expected/migrate-continuous-deploy.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/basic-production/expected/webserver.yaml | Updates expected output to remove the Namespace document from rendered YAML. |
| tests/scenarios/basic-production/expected/namespace.yaml | Removes the expected namespace manifest fixture. |
| tests/scenarios/basic-production/expected/migrate-first-deploy.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/basic-production/expected/migrate-first-deploy-with-demo-data.yaml | Removes the Namespace document from expected rendered output. |
| tests/scenarios/basic-production/expected/migrate-continuous-deploy.yaml | Removes the Namespace document from expected rendered output. |
| kubernetes/namespace.yaml | Deletes the namespace manifest template. |
| kubernetes/kustomize/webserver/kustomization.yaml | Removes namespace.yaml from kustomize resources. |
| kubernetes/kustomize/migrate-application/first-deploy/kustomization.yaml | Removes namespace.yaml from kustomize resources. |
| kubernetes/kustomize/migrate-application/first-deploy-with-demo-data/kustomization.yaml | Removes namespace.yaml from kustomize resources. |
| kubernetes/kustomize/migrate-application/continuous-deploy/kustomization.yaml | Removes namespace.yaml from kustomize resources. |
| kubernetes/horizontalStorefrontAutoscaler.yaml | Removes hardcoded namespace from HPA metadata. |
| kubernetes/horizontalPodAutoscaler.yaml | Removes hardcoded namespace from HPA metadata. |
| deploy/parts/deploy.sh | Applies kustomize output using kubectl apply -n ${PROJECT_NAME}. |
| UPGRADE.md | Documents the change for v5.1.0 upgrade notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.