improved probes and graceful shutdown for storefront#76
Open
henzigo wants to merge 1 commit intojg/rabbitmq-probesfrom
Open
improved probes and graceful shutdown for storefront#76henzigo wants to merge 1 commit intojg/rabbitmq-probesfrom
henzigo wants to merge 1 commit intojg/rabbitmq-probesfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Kubernetes Deployment configuration for the storefront container to improve startup behavior, health probing, and termination handling, and refreshes the scenario “expected” manifests accordingly.
Changes:
- Add a
startupProbeforstorefrontand tunelivenessProbe/readinessProbetimings and thresholds. - Adjust
preStophook to run via/bin/sh -lc(sleep delay before termination). - Document the change in
UPGRADE.mdand update test scenario expected manifests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
kubernetes/deployments/storefront.yaml |
Adds startupProbe, tunes liveness/readiness probes, and updates preStop command for storefront. |
tests/scenarios/basic-production/expected/webserver.yaml |
Updates expected manifest output for the new probe + preStop configuration. |
tests/scenarios/development-single-domain/expected/webserver.yaml |
Updates expected manifest output for the new probe + preStop configuration. |
tests/scenarios/escaping-env/expected/webserver.yaml |
Updates expected manifest output for the new probe + preStop configuration. |
tests/scenarios/production-with-cloudflare/expected/webserver.yaml |
Updates expected manifest output for the new probe + preStop configuration. |
UPGRADE.md |
Adds an upgrade note referencing this change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.