Skip to content

improved probes and graceful shutdown for storefront#76

Open
henzigo wants to merge 1 commit intojg/rabbitmq-probesfrom
jg/sf-graceful-shutdown
Open

improved probes and graceful shutdown for storefront#76
henzigo wants to merge 1 commit intojg/rabbitmq-probesfrom
jg/sf-graceful-shutdown

Conversation

@henzigo
Copy link
Copy Markdown
Member

@henzigo henzigo commented Apr 15, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Kubernetes Deployment configuration for the storefront container to improve startup behavior, health probing, and termination handling, and refreshes the scenario “expected” manifests accordingly.

Changes:

  • Add a startupProbe for storefront and tune livenessProbe / readinessProbe timings and thresholds.
  • Adjust preStop hook to run via /bin/sh -lc (sleep delay before termination).
  • Document the change in UPGRADE.md and update test scenario expected manifests.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kubernetes/deployments/storefront.yaml Adds startupProbe, tunes liveness/readiness probes, and updates preStop command for storefront.
tests/scenarios/basic-production/expected/webserver.yaml Updates expected manifest output for the new probe + preStop configuration.
tests/scenarios/development-single-domain/expected/webserver.yaml Updates expected manifest output for the new probe + preStop configuration.
tests/scenarios/escaping-env/expected/webserver.yaml Updates expected manifest output for the new probe + preStop configuration.
tests/scenarios/production-with-cloudflare/expected/webserver.yaml Updates expected manifest output for the new probe + preStop configuration.
UPGRADE.md Adds an upgrade note referencing this change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants