Conversation
There was a problem hiding this comment.
Pull request overview
Adds production-only TTFB monitoring by generating Prometheus Operator Probe resources (via blackbox-exporter) and introduces test scenarios validating domain selection, path normalization, and HTTP basic-auth embedding.
Changes:
- Add
deploy/parts/probes.shto generate TTFBProbemanifests and include them in webserver kustomization. - Add a
Probemanifest template underkubernetes/manifest-templates/. - Add three test scenarios (
ttfb-default-domain,ttfb-custom-domain,ttfb-http-auth) with expected rendered manifests and scenario wiring; document usage inREADME.mdand upgrade steps inUPGRADE.md.
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
deploy/parts/probes.sh |
Generates Probe YAMLs from TTFB_PROBES, optionally embeds HTTP auth, and amends kustomization resources. |
kubernetes/manifest-templates/probe.template.yaml |
Template for Prometheus Operator Probe objects used by the generator. |
tests/lib/scenario-base.sh |
Ensures probe generation runs as part of scenario manifest generation. |
tests/scenarios/** |
Adds scenarios and golden expected outputs covering default/custom/auth-protected probe targets. |
README.md |
Documents how to enable/configure TTFB probes. |
UPGRADE.md |
Notes upgrade steps for enabling probes in downstream projects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds production-only TTFB monitoring by generating Prometheus Operator Probe resources (via blackbox-exporter)