Conversation
Signed-off-by: Hasan Awad <hasan.m.awad94@gmail.com>
hasanawad94
added
the
kind/dependency-change
pull-request-size
Bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Hasan Awad <hasan.m.awad94@gmail.com>
hasanawad94
force-pushed
the
bump-k8s-v19
branch
3 times, most recently
from
8af7a8e to
58f6dfe
Compare
pull-request-size
Bot
added
size/L
hasanawad94
force-pushed
the
bump-k8s-v19
branch
from
58f6dfe to
256e4d0
Compare
Upgrade controller-gen to a version compatible with Go 1.25 Ran make bundle and updated sdk version in install-operator-sdk.sh Signed-off-by: Hasan Awad <hasan.m.awad94@gmail.com>
hasanawad94
force-pushed
the
bump-k8s-v19
branch
from
256e4d0 to
4a104de
Compare
|
/lgtm CC: @shipwright-io/maintainers for review/approval |
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
Got a few questions before I'm ready to mark this "approved".
I think you can also squash commits (and please provide a detailed explanation of the "why" behind the operator-sdk update in your commit message).
|
|
||
| DEST="${1:-bin/operator-sdk}" | ||
| SDK_VERSION="${SDK_VERSION:-1.18.0}" | ||
| SDK_VERSION="${SDK_VERSION:-1.32.0}" |
There was a problem hiding this comment.
Does this fix #139 ?!
I thought operator-sdk enforced strict layouts for supported operators. Is that not the case any more?
There was a problem hiding this comment.
The generate and bundle commands work the same way and haven't changed in any breaking way between those versions.
I saw that the v1.33 release made go/v4 the default plugin for new projects
https://github.com/operator-framework/operator-sdk/releases/tag/v1.33.0
| bundle: manifests kustomize operator-sdk ko ## Generate bundle manifests and metadata, then validate generated files. | ||
| $(OPERATOR_SDK) generate kustomize manifests --interactive=false -q | ||
| $(KUSTOMIZE) build config/manifests | $(OPERATOR_SDK) generate bundle $(BUNDLE_GEN_FLAGS) | ||
| $(SED_BIN) -i.bak '/^ createdAt: /d' bundle/manifests/shipwright-operator.clusterserviceversion.yaml && rm -f bundle/manifests/shipwright-operator.clusterserviceversion.yaml.bak |
There was a problem hiding this comment.
This warrants a bit of explanation - why is this necessary?
There was a problem hiding this comment.
Yes my bad for not explaining. The verify-bundle step in ci.yml was failing with this error after changing to operator-sdk to v1.32.0:
Differences:
diff --git a/bundle/manifests/shipwright-operator.clusterserviceversion.yaml b/bundle/manifests/shipwright-operator.clusterserviceversion.yaml
index 4208885..363a693 100644
--- a/bundle/manifests/shipwright-operator.clusterserviceversion.yaml
+++ b/bundle/manifests/shipwright-operator.clusterserviceversion.yaml
@@ -19,7 +19,7 @@ metadata:
categories: Developer Tools
certified: "false"
containerImage: ko://github.com/shipwright-io/operator
- createdAt: "2026-02-24T09:19:08Z"
+ createdAt: "2026-02-24T09:23:16Z"
description: Shipwright is a framework for building container images on Kubernetes.
operators.operatorframework.io/builder: operator-sdk-v1.32.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
+ exit 1
make: *** [Makefile:244: verify-bundle] Error 1
Error: Process completed with exit code 2.
Its regenerating the createdAt when make bundle runs which didnt happen in v1.18.0. So I thought to strip the createdAt for now.
There was a problem hiding this comment.
Please add a comment documenting this issue. I'd love to move off operator-sdk entirely, but that is a bigger issue for another day.
Signed-off-by: Hasan Awad <hasan.m.awad94@gmail.com>
hasanawad94
force-pushed
the
bump-k8s-v19
branch
from
edc6a6c to
ac919d0
Compare
IrvingMg
left a comment
IrvingMg
left a comment
There was a problem hiding this comment.
/lgtm
Please squash the commits.
4 participants
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes