[shipcloudsebastiaan]

• declare dynamic properties on lessc, lessc_parser and lessc_formatter_classic
• replace ${var} interpolation with {$var}
• pass 0 instead of null as preg_match() flags
• cast float to int before modulo in color parsing

[Copilot]

🟡 Changes recommended

Two remaining assignments can still create deprecated dynamic properties.

2 open findings

• Declare _parseFile to prevent dynamic properties in deprecated constructor · New
• Declare currentProperty to prevent dynamic properties in assign() · New

What changed in this PR

Updates lessphp for PHP 8.4 compatibility by removing several deprecated behaviors.

Changes:

• Declares runtime state properties.
• Updates interpolation and preg_match() flags.
• Prevents implicit float-to-int conversion during color parsing.

File	Description
lessc.inc.php	Addresses property, interpolation, regex, and modulo deprecations.
lessify.inc.php	Uses integer flags for preg_match().

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Fatal PHP 8 syntax and additional float-modulo deprecations remain unresolved.

1 open finding

• Replace deprecated string offset syntax for PHP 8 compatibility · New

2 resolved since last review

• Declare currentProperty to prevent dynamic properties in assign()
• Declare _parseFile to prevent dynamic properties in deprecated constructor

Previously missed (1)

In code that hasn't changed since last review

Handle fractional operands at all modulo operations

lessc.inc.php:1683

This cast only removes the float-to-int deprecation from raw-color parsing. Fractional LESS operands still reach PHP's integer-only % operator in lib_mod() (line 908) and op_number_number() (line 1892), so inputs such as mod(5.5, 2) or 5.5 % 2 continue to emit the same deprecation on PHP 8.4. Explicitly preserve the intended integer conversion at all such modulo sites (or use fmod() if fractional modulo is intended).

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The changes are localized, complete, and preserve existing behavior while resolving the targeted deprecations.

0 open findings

1 resolved since last review

• Replace deprecated string offset syntax for PHP 8 compatibility

🧠 Review effort: Balanced