Repository navigation
Fix MultiSelect bulk selection and Paginator previous item navigation - #403
Merged
Merged
Conversation
- Ctrl+A and Ctrl+I now respect the Maximum option and show an error instead of exceeding it - Ctrl+A and Ctrl+I only affect the currently filtered items, so selections hidden by the filter are preserved - Pressing Up with nothing selected now selects the last item on the current page instead of jumping to the previous page Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the described behavior and includes focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes bulk selection under filtering/maximum constraints and corrects upward navigation without an active selection.
Changes:
- Applies Ctrl+A/Ctrl+I only to filtered items while preserving hidden selections.
- Enforces
Maximumbefore committing bulk selection changes. - Keeps
PreviousItemon the current page when nothing is selected.
| File | Description |
|---|---|
src/Sharprompt/Forms/MultiSelectForm.cs |
Corrects bulk-selection behavior and maximum enforcement. |
src/Sharprompt/Internal/Paginator.cs |
Corrects previous-item navigation without a selection. |
tests/Sharprompt.Tests/Forms/FormInteractionTests.cs |
Covers bulk selection, filtering, and maximum constraints. |
tests/Sharprompt.Tests/Internal/PaginatorTests.cs |
Covers previous-item page behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maximum: bulk selection could exceed the configured maximum. Both now compute the new selection first and show the maximum-selection error (leaving the selection unchanged) if it would exceedMaximum.LoopingSelectionisfalse, e.g. after moving pages with ←/→). It now selects the last item on the current page, mirroring how Down selects the first item.Tests
PreviousItem.masterand pass with this change; the full suite (690 tests, net8.0 / net10.0) passes.🤖 Generated with Claude Code