Skip to content

docs(readme): add ShellTime logo header - #17

Merged
AnnatarHe merged 1 commit into
mainfrom
claude/loving-volta-qh9zkx
Oct 9, 2026
Merged

AnnatarHe merged 1 commit into
mainfrom
claude/loving-volta-qh9zkx

Conversation

@AnnatarHe

Copy link
Copy Markdown
Contributor

Summary

Neovim plugins have nowhere to show an icon: no marketplace listing and no statusline glyph in this plugin. So the new ShellTime logo from shelltime/web#657 goes in the README instead.

  • assets/logo.svg: a verbatim copy of the web repo's src/assets/logo/logo.github.svg.
  • README.md: shows the logo centered above the # shelltime.nvim title.

No Lua code changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GRR68kM5sbWqBV1aHyeyug


Generated by Claude Code

assets/logo.svg is a copy of the web repo's logo.github.svg.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GRR68kM5sbWqBV1aHyeyug
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@claude

claude Bot commented Oct 9, 2026

Copy link
Copy Markdown

Review: docs-only change (README header + assets/logo.svg). No Lua changes, so no test or performance impact.

Looks good

  • The SVG is clean: no scripts, external references or embedded data. Nothing to worry about security-wise.
  • The relative path assets/logo.svg renders on GitHub. The width/height on the <img> keep the 1000px SVG at 96px.

Minor suggestions (non-blocking)

  1. The logo has an opaque light background (#f8fafc to #e0f2fe), so it will show as a light square in GitHub dark mode. If that looks off, use a transparent or rounded-rect background, or a <picture> with a dark variant.
  2. The SVG is 1000x1000 with a 256 viewBox. This works, but a smaller intrinsic size (e.g. 256) is tidier, though the README already constrains it. Since the file is meant to be a verbatim copy, I'd leave it.
  3. If the logo is also meant to be a repo social preview, GitHub needs a PNG/JPG, because it doesn't accept SVG there.

LGTM.

@AnnatarHe
AnnatarHe merged commit b8ad973 into main Oct 9, 2026
3 checks passed
@AnnatarHe
AnnatarHe deleted the claude/loving-volta-qh9zkx branch October 9, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants