docs: one tag for every picture on a page - #7020
Merged
Merged
Conversation
A page had three ways to show the product: a <Shot> for a screenshot the capture pipeline produces, a markdown image for a file made by hand, and a <Clip> for a recorded interaction. Each carried its own frame, its own sizing and its own behaviour on click - the markdown one needed a script to be reachable by keyboard at all. <Shot> takes all three now, and the source says which it is: id for a capture, src for a file that exists, clip for a recording. One frame, one ceiling, one zoom, and the frame follows the picture instead of the column. The ceiling differs by kind, because the pictures do: a capture is a whole window and earns the column, while a file made by hand is usually a crop of one dialog, which at that width renders an interface larger than the text around it.
|
Claude finished @gustavosbarreto's task in 1m 19s —— View job Code Review CompleteReviewed 13 files across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is. A few observations (informational, not blocking):
To request another review round, comment |
|
Documentation preview: https://845fe3e7.shellhub-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A page had three ways to show the product, and they had drifted apart. A
<Shot>for a screenshot the capture pipeline produces. A markdown image for a file somebody made by hand. A<Clip>for a recorded interaction. Each carried its own frame, its own sizing and its own behaviour on click — the markdown one needed a script in the layout to become reachable by keyboard at all, and the clip did not enlarge.<Shot>takes all three now, and the source says which kind it is:Only the first declares anything to the capture pipeline; the other two are files. All three get one frame, one ceiling on size, and enlarge on click, so the special-casing in the layout script and the stylesheet is gone along with the
<Clip>component.The frame now follows the picture rather than the column, so a narrow one no longer sits in a wide box of empty surface. The ceiling differs by kind, because the pictures do: a capture is a whole window, its interface is already small, and it earns the column; a file made by hand is usually a crop of a single dialog, and at column width the interface inside it renders larger than the text around it — the MFA recovery dialog went from 696x473 to 542x368, while the device list still fills the column.