Skip to content

fix(openapi): fix recorded session GET response - #7017

Merged
otavio merged 1 commit into
masterfrom
fix/openapi/session-recording-response
Sep 2, 2026
Merged

fix(openapi): fix recorded session GET response#7017
otavio merged 1 commit into
masterfrom
fix/openapi/session-recording-response

Conversation

@luizhf42

@luizhf42 luizhf42 commented Sep 2, 2026

Copy link
Copy Markdown
Member

What

Fix the session recording GET response type.

Why

The spec previously typed this as a whole schema, but that endpoint only returns the session contents in NDJSON, recorded via Asciinema.

Closes shellhub-io/team#237

@luizhf42 luizhf42 self-assigned this Sep 2, 2026
@luizhf42
luizhf42 requested a review from a team as a code owner September 2, 2026 16:52
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Claude finished @luizhf42's task in 46s —— View job


Code Review Complete

Reviewed 2 files across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is.

I verified against the actual handler in cloud/internal/cloud/routes/session.go (GetSessionAnsciinema), which serves the recorded session file directly via c.FileFS(...) rather than returning a structured JSON object — so switching the 200 response from application/json + recordedSessionResponse to text/plain + type: string correctly reflects the real behavior. I also confirmed the deleted recordedSessionResponse.yaml schema has no remaining $ref references anywhere in openapi/.

If you push additional changes and want a new review, tag @shellhub-io/admin and a team member can trigger it.

@otavio
otavio merged commit fbbd349 into master Sep 2, 2026
72 of 104 checks passed
@otavio
otavio deleted the fix/openapi/session-recording-response branch September 2, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants