You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed 2 files across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is.
I verified against the actual handler in cloud/internal/cloud/routes/session.go (GetSessionAnsciinema), which serves the recorded session file directly via c.FileFS(...) rather than returning a structured JSON object — so switching the 200 response from application/json + recordedSessionResponse to text/plain + type: string correctly reflects the real behavior. I also confirmed the deleted recordedSessionResponse.yaml schema has no remaining $ref references anywhere in openapi/.
If you push additional changes and want a new review, tag @shellhub-io/admin and a team member can trigger it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the session recording GET response type.
Why
The spec previously typed this as a whole schema, but that endpoint only returns the session contents in NDJSON, recorded via Asciinema.
Closes shellhub-io/team#237