docs: stop a portrait screenshot taking the whole page - #7016
Merged
Conversation
An image was given the column's width, so a tall one - the MFA dialogs, where the picture is a phone-shaped panel - rendered near a thousand pixels high to show a small dialog, and the reader scrolled past a screenful of it. Height is capped and width follows, so a picture takes about as much of the page as it is worth. Clicking one still opens it at full size.
|
Claude finished @gustavosbarreto's task in 28s —— View job Code Review CompleteReviewed 2 files across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is. The To request another review round, comment |
|
Documentation preview: https://82762b5d.shellhub-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An image in the prose was given the column's width, which is right for a screenshot of a table and wrong for a tall one. The MFA dialogs are phone-shaped panels, so they rendered near a thousand pixels high to show a small dialog, and the reader scrolled through a screenful of picture to get to the next sentence.
The cap is on height now, with width following in proportion and the image centred, so a picture takes about as much of the page as it is worth: the device list still fills the column, the MFA dialogs come down from 696x996 to 336x480. Clicking one still opens it at full size, which is where somebody goes to read the detail.
The same ceiling applies inside a
<Shot>, so a captured screenshot that happens to be tall behaves the same way.