Skip to content

docs: answer 404 for a page that is not there - #7015

Merged
gustavosbarreto merged 1 commit into
masterfrom
docs/not-found
Sep 2, 2026
Merged

docs: answer 404 for a page that is not there#7015
gustavosbarreto merged 1 commit into
masterfrom
docs/not-found

Conversation

@gustavosbarreto

Copy link
Copy Markdown
Member

The site ships no 404 page, so the host falls back to the home page. A mistyped address, a link from the documentation this one replaced, or a page since retired all answer 200 with the front page: the reader is told nothing went wrong and left to work out why the page looks unrelated, and a crawler records the home page under a second address.

There is a page now, in the documentation's own layout, saying what happened and offering the search and three places to start.

The site ships no 404 page, so the host falls back to the home page: a
mistyped address, or one this documentation retired, answers 200 with the
front page. The reader is told nothing went wrong, and a crawler records
the home page under a second address.
@gustavosbarreto
gustavosbarreto requested a review from a team as a code owner September 2, 2026 14:16
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Documentation preview: https://be187a9e.shellhub-docs.pages.dev

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Claude finished @gustavosbarreto's task in 53s —— View job


Code Review Complete

Reviewed 2 files across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is.

Verified:

  • The three start links (/introduction, /get-started, /help/troubleshooting) all resolve to existing page files.
  • DocsLayout accepts the title/description props passed in.
  • /404 is added to PAGES_NOT_IN_NAV, so the orphan-page integrity test in sidebar.test.ts still passes for the new route.
    · docs/not-found

@gustavosbarreto
gustavosbarreto merged commit 55beca5 into master Sep 2, 2026
41 checks passed
@gustavosbarreto
gustavosbarreto deleted the docs/not-found branch September 2, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant