Repository navigation
feat: add window_title to shpool list --json - #441
Open
GeoffChurch wants to merge 1 commit into
Open
GeoffChurch wants to merge 1 commit into
GeoffChurch wants to merge 1 commit into
Conversation
GeoffChurch
force-pushed
the
session-titles
branch
2 times, most recently
from
October 7, 2026 17:31
d52638e to
4baf484
Compare
Contributor
|
I think you'll need to pull in shpool-vterm 0.2.7 (shell-pool/shpool-vterm#12) |
ethanpailes
reviewed
Oct 7, 2026
GeoffChurch
force-pushed
the
session-titles
branch
from
October 7, 2026 18:20
4baf484 to
68a0920
Compare
ethanpailes
reviewed
Oct 7, 2026
ethanpailes
left a comment
Contributor
There was a problem hiding this comment.
I'd like to take a different approach to avoid double-storing the same data.
Contributor
|
I just bumped the shpool-vterm version to 0.2.8, so you should be able to rebase and impl |
See discussion shell-pool#440
GeoffChurch
force-pushed
the
session-titles
branch
from
October 23, 2026 18:33
68a0920 to
d61f5d1
Compare
ethanpailes
reviewed
Oct 23, 2026
| .collect() | ||
| }; | ||
| let (mut sessions, replies): (Vec<Session>, Vec<Reply>) = | ||
| sessions.context("collecting running session metadata")?.into_iter().unzip(); |
Contributor
There was a problem hiding this comment.
It looks like we unzip here only to zip back together below. That seems a bit goofy. Let's just keep the tuples together.
ethanpailes
reviewed
Oct 23, 2026
| fn handle_fetch_metadata( | ||
| spool: &dyn session_restore::SessionSpool, | ||
| request: Result<MetadataRequest, crossbeam_channel::RecvError>, | ||
| requests: &mut crossbeam_channel::Receiver<MetadataRequest>, |
Contributor
There was a problem hiding this comment.
Draining other incoming requests immediately seems overly complicated. Let's just handled one at a time and use the top level dispatch loops for all incoming requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
Discussion #440
AI Policy Ack
ack
Drafted with vibes, edited and tested with meat
This PR was:
Description
Adds
window_titleto the output ofshpool list --json:The use case is letting downstream tools show the user the window titles of their sessions. Many processes (shells, coding assistants, etc) send status information to the window title, which is traditionally visible in a terminal window/tab but in shpool is inaccessible without attaching to the session.
This change exposes the current title through
shpool list --jsonwithout attaching.