-
Notifications
You must be signed in to change notification settings - Fork 1
cleanOutput and @@meta('doc:ignore', true) #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lsmith77
wants to merge
5
commits into
sheldonj:main
Choose a base branch
from
lsmith77:cleanOutput
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f493f96
chore(deps): bump actions/checkout from 4 to 6
dependabot[bot] bbb3a23
fix flaky tests
lsmith77 017e93b
fix #10, add cleanOutput option
lsmith77 218d8d7
fix #15, add support for @@meta('doc:ignore', true) in includeInterna…
lsmith77 3ed60fd
add tests for cleanOutput and @@meta('doc:ignore', true)
lsmith77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import plugin from '../../src'; | ||
| import { loadSchema } from '../utils'; | ||
| import fs from 'node:fs'; | ||
| import os from 'node:os'; | ||
| import path from 'node:path'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| describe('documentation plugin: plugin options', () => { | ||
| it('cleanOutput deletes existing files in the output directory before generation', async () => { | ||
| const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'doc-plugin-')); | ||
| // create a stale file that should be removed by cleanOutput | ||
| fs.writeFileSync(path.join(tmpDir, 'stale.txt'), 'stale'); | ||
|
|
||
| const model = await loadSchema(` | ||
| model A { | ||
| id String @id @default(cuid()) | ||
| } | ||
| `); | ||
|
|
||
| await plugin.generate({ | ||
| defaultOutputPath: tmpDir, | ||
| model, | ||
| pluginOptions: { cleanOutput: true, output: tmpDir }, | ||
| schemaFile: 'schema.zmodel', | ||
| }); | ||
|
|
||
| // ensure output dir is prepopulated and removed by cleanOutput | ||
|
|
||
| expect(fs.existsSync(path.join(tmpDir, 'stale.txt'))).toBe(false); | ||
| expect(fs.existsSync(path.join(tmpDir, 'index.md'))).toBe(true); | ||
| }); | ||
| it("models with @@meta('doc:ignore', true) are treated as internal and excluded when includeInternalModels is false", async () => { | ||
| const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'doc-plugin-')); | ||
|
|
||
| const schema = ` | ||
| model Public { | ||
| id String @id @default(cuid()) | ||
| } | ||
|
|
||
| model Internal { | ||
| id String @id @default(cuid()) | ||
| @@meta('doc:ignore', true) | ||
| } | ||
| `; | ||
|
|
||
| const model = await loadSchema(schema); | ||
|
|
||
| await plugin.generate({ | ||
| defaultOutputPath: tmpDir, | ||
| model, | ||
| pluginOptions: { includeInternalModels: false, output: tmpDir }, | ||
| schemaFile: 'schema.zmodel', | ||
| }); | ||
|
|
||
| // Public model should be present, internal model should be excluded | ||
| expect(fs.existsSync(path.join(tmpDir, 'models', 'Public.md'))).toBe(true); | ||
| expect(fs.existsSync(path.join(tmpDir, 'models', 'Internal.md'))).toBe( | ||
| false, | ||
| ); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.