fix(s16): resume teammate after plan approval - #499
Open
ivaris03 wants to merge 1 commit into
Open
Conversation
ivaris03
marked this pull request as ready for review
August 1, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_approval_responseis receivedRoot cause
The idle loop handled
plan_approval_responsebut did not treat it as a resume signal. When another inbox message did break the idle loop, execution fell through to the tool-result path for a response with no tool calls, appending an empty user content list. The next API call could fail and the teammate thread would exit because that exception is swallowed by the teaching harness.Validation
python -m pytest -q tests/test_s16_team_protocols.pypython -m pytest -q(25 passed, 30 subtests passed)python -m py_compile s16_team_protocols/code.py tests/test_s16_team_protocols.pygit diff --checkCloses #455