Fix s07 skill frontmatter parsing edge cases - #434
Open
Bill-Billion wants to merge 3 commits into
Open
Conversation
|
@Bill-Billion is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
Closed
|
The fix in I noticed that Before merging, please check s08 through s20 and synchronize any skill loading / frontmatter parsing code that still builds on the s07 implementation. It would also be helpful to mention which later chapters were checked. |
Bill-Billion
force-pushed
the
main
branch
2 times, most recently
from
July 28, 2026 12:24
934b526 to
581241c
Compare
…b#434 Replace old manual/split-based _parse_frontmatter with the line-delimited YAML parser from s07. This fixes skill loading for YAML block scalars, multiline descriptions, and CRLF line endings in both s08 and s20. Also update name/desc fallback from meta.get(k, default) to meta.get(k) or default so empty string values correctly fall through. s08 previously used a manual split(':', 1) parser that could not handle YAML syntax at all. s20 used yaml.safe_load but with the old text.split('---', 2) approach that misses boundary cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
---fences.nameordescriptionis empty.Fixes #430
Verification
python3 -m py_compile s07_skill_loading/code.pyyaml.safe_loadshim, covering normal metadata, non-frontmatter text, scalar YAML, missing description, and empty name.git diff --checkpytest -q-> 24 passed, 30 subtests passed