Fix command injection vulnerability in tool_list_files#3
Open
luojiyin1987 wants to merge 2 commits intoshareAI-lab:mainfrom
Open
Fix command injection vulnerability in tool_list_files#3luojiyin1987 wants to merge 2 commits intoshareAI-lab:mainfrom
luojiyin1987 wants to merge 2 commits intoshareAI-lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a command injection vulnerability in the
tool_list_files()function in/lib/tools.sh. The vulnerability was caused by using string concatenation to build find command arguments, which could allow malicious file patterns containing special characters to execute arbitrary commands.Changes Made
find_argsvariable from string to array type${find_args[@]})Impact
This fix prevents command injection vulnerabilities when the
tool_list_filesfunction is used with untrusted input for file patterns.Testing
closed #2