Expose BGEN tuning options#32
Merged
Merged
Conversation
vcztools.BgenEncoder accepts total_string_length and pad_byte but ViewBgenOptions does not yet surface them. Add a temporary biofuse/_vcztools_compat.py shim that subclasses ViewBgenOptions to add the two fields, layers --total-string-length and --pad-byte onto the existing decorator, and extends from_click_kwargs to read them. _bgen_encoder_factory passes the new fields straight to BgenEncoder; nothing else in cli.py / encoder_host.py changes. Delete the shim (and the TestViewBgenOptionsShim class) once the fields land in vcztools upstream.
The --total-string-length and --pad-byte options have landed in vcztools.ViewBgenOptions, so the biofuse-local monkeypatch is no longer needed. Bumps the vcztools lock past commit a8ce91d and loosens the non-ASCII pad-byte CLI test to match upstream's strict encoder, which raises UnicodeEncodeError instead of BadParameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.