Added checking if message has attachment before showing delete dialog#603
Open
mikoldin123 wants to merge 2 commits into
Open
Conversation
mikoldin123
added
enhancement
mikoldin123
force-pushed
the
feat/SES-2095/associated_message_deletion_alert
branch
from
October 7, 2025 00:33
a1d8d8d to
fddf785
Compare
mikoldin123
changed the title
mikoldin123
force-pushed
the
feat/SES-2095/associated_message_deletion_alert
branch
3 times, most recently
from
October 7, 2025 06:12
d190498 to
8b22d81
Compare
mikoldin123
marked this pull request as ready for review
October 7, 2025 06:18
mikoldin123
changed the title
mikoldin123
marked this pull request as draft
October 8, 2025 06:25
mikoldin123
changed the title
mikoldin123
force-pushed
the
feat/SES-2095/associated_message_deletion_alert
branch
from
October 8, 2025 06:38
8b22d81 to
9e923e1
Compare
mikoldin123
changed the title
mikoldin123
marked this pull request as ready for review
October 8, 2025 06:39
mpretty-cyro
requested changes
Oct 12, 2025
mpretty-cyro
left a comment
mpretty-cyro
left a comment
Collaborator
There was a problem hiding this comment.
So it looks like the requirements for this change were not really clarified at all, the change we want is to show the "delete for me/everyone" modal with the new copy if you try to delete attachments via the Conversation -> Settings -> Attachment section (either individually or via multi-select) - currently it looks like this:
The copy for deleting a message with an attachment from within the conversation screen shouldn't be changed
Collaborator
Author
|
mikoldin123
force-pushed
the
feat/SES-2095/associated_message_deletion_alert
branch
4 times, most recently
from
October 13, 2025 08:05
0c57512 to
af7c364
Compare
mikoldin123
force-pushed
the
feat/SES-2095/associated_message_deletion_alert
branch
from
October 14, 2025 01:35
af7c364 to
55b1570
Compare
mikoldin123
force-pushed
the
feat/SES-2095/associated_message_deletion_alert
branch
from
October 14, 2025 05:56
55b1570 to
cb5901f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://www.figma.com/design/kau6LggVcMMWmZRMibEo8F/Standardise-Message-Deletion?node-id=1134-930&m=dev