fix #127 - feat: Implement Storybook structure and styling#151
Open
cheryl7114 wants to merge 10 commits into
Open
fix #127 - feat: Implement Storybook structure and styling#151cheryl7114 wants to merge 10 commits into
cheryl7114 wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the serverless-workflow-diagram-editor package’s Storybook setup by removing the default Storybook “Example” boilerplate components/docs and aligning the remaining stories under a Features/* hierarchy with corrected source import paths.
Changes:
- Removed Storybook starter boilerplate (Button/Header/Page components, CSS, and Configure docs MDX).
- Reorganized remaining stories under
Features/*titles for clearer navigation. - Fixed story imports to reference the package
src/from thestories/features/directory (e.g.,../../src/...).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/stories/Page.tsx | Removed Storybook starter “Page” boilerplate component. |
| packages/serverless-workflow-diagram-editor/stories/Page.stories.ts | Removed Storybook starter “Page” story (incl. interaction test). |
| packages/serverless-workflow-diagram-editor/stories/page.css | Removed CSS used only by the deleted starter “Page”. |
| packages/serverless-workflow-diagram-editor/stories/Header.tsx | Removed Storybook starter “Header” boilerplate component. |
| packages/serverless-workflow-diagram-editor/stories/Header.stories.ts | Removed Storybook starter “Header” story. |
| packages/serverless-workflow-diagram-editor/stories/header.css | Removed CSS used only by the deleted starter “Header”. |
| packages/serverless-workflow-diagram-editor/stories/Configure.mdx | Removed Storybook starter Configure docs page. |
| packages/serverless-workflow-diagram-editor/stories/Button.tsx | Removed Storybook starter “Button” boilerplate component. |
| packages/serverless-workflow-diagram-editor/stories/Button.stories.ts | Removed Storybook starter “Button” story. |
| packages/serverless-workflow-diagram-editor/stories/button.css | Removed CSS used only by the deleted starter “Button”. |
| packages/serverless-workflow-diagram-editor/stories/features/ErrorPage.stories.tsx | Updated imports to ../../src/... and renamed story title to Features/ErrorPage. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditorDragNDrop.tsx | Updated import path to ../../src/diagram-editor/DiagramEditor. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditorDragNDrop.stories.ts | Renamed story title to Features/Diagram-Editor-Drag-N-Drop. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditor.tsx | Updated import path to ../../src/diagram-editor/DiagramEditor. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditor.stories.ts | Renamed story title to Features/Diagram-Editor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cheryl7114
changed the title
Member
fantonangeli
left a comment
fantonangeli
left a comment
There was a problem hiding this comment.
LGTM, Just 2 small suggestions
Thanks @cheryl7114
added 6 commits
May 26, 2026 12:40
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
cheryl7114
force-pushed
the
storybook-styling-127
branch
from
36b47dd to
a7d09e8
Compare
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
@ricardozanini our Netlify configuration is working 🚀 |
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
…e support Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127
Description
This PR implements the following changes to Storybook: