Skip to content

feat: Adding support for failure policy#132

Open
patrickhousley wants to merge 4 commits into
serverless:masterfrom
patrickhousley:master
Open

feat: Adding support for failure policy#132
patrickhousley wants to merge 4 commits into
serverless:masterfrom
patrickhousley:master

Conversation

@patrickhousley

@patrickhousley patrickhousley commented Nov 2, 2018

Copy link
Copy Markdown

This PR adds support for setting eventTrigger failurePolicy on individual functions.

@zdraganov

zdraganov commented Jan 4, 2019

Copy link
Copy Markdown

Related to #131

@zdraganov

zdraganov commented Jan 4, 2019 •
edited
Loading

Copy link
Copy Markdown

@patrickhousley it's good to add something into the README when you are extending current code

@patrickbrandt

patrickbrandt commented Jan 5, 2019

Copy link
Copy Markdown

@patrickhousley ^

@patrickhousley

patrickhousley commented Jan 6, 2019

Copy link
Copy Markdown
Author

Sorry fellows, been on vacation. So I would normally agree if the README was actually used for documentation. However, it is not in this repo. I will leave it to the repo maintainers to decide how best to document this change.

@patrickhousley

patrickhousley commented May 3, 2019

Copy link
Copy Markdown
Author

Is this going to be merged? If not, please close it and explain why.

@teddy-codes

teddy-codes commented Aug 9, 2019

Copy link
Copy Markdown

LGTM?

@hjaurum

hjaurum commented Nov 4, 2019

Copy link
Copy Markdown

can merge this PR? really need it ~

@buffolander

buffolander commented Dec 8, 2019 •
edited
Loading

Copy link
Copy Markdown


is anyone gonna merge this PR? @pmuens

@gretro

gretro commented Jan 7, 2020

Copy link
Copy Markdown

Is there a plan to merge this PR? It would be helpful.

@paulohpigatto

paulohpigatto commented Apr 6, 2020

Copy link
Copy Markdown

Is this PR still active? The changes would be extremely useful

@frandiox

frandiox commented Jun 5, 2020

Copy link
Copy Markdown

@patrickhousley Thanks for the PR! Just pinging in case you didn't notice the tests failed. It seems easy to fix and perhaps we can ping the other collaborators after tests pass to get this merged.

EthanChouTW added a commit to AlleyPin/serverless-google-cloudfunctions that referenced this pull request Jul 22, 2020
@EthanChouTW
feat: adding support for failure policy
6404a47 
following serverless#132
@EthanChouTW EthanChouTW mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mickdekkers mickdekkers mickdekkers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@patrickhousley @zdraganov @patrickbrandt @teddy-codes @hjaurum @buffolander @gretro @paulohpigatto @frandiox @mickdekkers