fix: uikit-utils should be permissive to replaced global Promise - #315
Open
grizio wants to merge 1 commit into
Open
fix: uikit-utils should be permissive to replaced global Promise#315grizio wants to merge 1 commit into
grizio wants to merge 1 commit into
Conversation
Some environments replace `global.Promise` with a polyfill at startup. I happen to encounter this case using new-relic agent for monitoring reasons. This commit makes the use of Promise vs function more permissive to these replaced Promises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some environments replace
global.Promisewith a polyfill at startup. I happen to encounter this case using new-relic agent for monitoring reasons.This commit makes the use of Promise vs function more permissive to these replaced Promises.
External Contributions
I tried to reach the email address given in the template description but got an error:
Here the email I prepared:
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_