Skip to content

fix: uikit-utils should be permissive to replaced global Promise - #315

Open
grizio wants to merge 1 commit into
sendbird:mainfrom
grizio:fix/permissive-promise
Open

fix: uikit-utils should be permissive to replaced global Promise#315
grizio wants to merge 1 commit into
sendbird:mainfrom
grizio:fix/permissive-promise

Conversation

@grizio

@grizio grizio commented Aug 11, 2026

Copy link
Copy Markdown

Some environments replace global.Promise with a polyfill at startup. I happen to encounter this case using new-relic agent for monitoring reasons.

This commit makes the use of Promise vs function more permissive to these replaced Promises.

External Contributions

I tried to reach the email address given in the template description but got an error:

Your message wasn't delivered to [truncated] because the address couldn't be found, or is unable to receive mail. 

Here the email I prepared:

Working with new-relic and currently installing Sendbird in our application, I encountered an incompatibility between the two libraries. I created a fix, visible here: https://github.com/sendbird/sendbird-uikit-react-native/compare/main...grizio:sendbird-uikit-react-native:fix/permissive-promise?expand=1

For the moment, I had to implement several workarounds (for now in channel creation screen and open channel screen) to avoid falling in this part of the library and I think this could happen to others.

Is it possible to setup a CLA? Otherwise, if you have other way to fix this issue, I would gladly accept.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

Some environments replace `global.Promise` with a polyfill at startup. I happen to encounter this case using new-relic agent for monitoring reasons.

This commit makes the use of Promise vs function more permissive to these replaced Promises.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant