Skip to content

fix(seidroid-review): read the finding counts where the driver writes them #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdchatham merged 1 commit into from
Sep 5, 2026
+8 −2
Merged

fix(seidroid-review): read the finding counts where the driver writes them #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/seidroid-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,10 +1204,16 @@ jobs:
# A driver older than these fields writes none of them and jq answers null. The
# sentinel makes that a value is_count rejects, so an old driver publishes the
# same comment with a shorter line that is still true.
# Under `counts`, which is where the driver writes them: check.json carries
# `counts: {blocking, non_blocking, placeable, pre_existing}` beside a
# top-level `conclusion`. Read at the ROOT they answered null on every run, so
# the line never printed a number, the notice below claimed the driver predates
# fields it has, and neither disagreement warning could fire -- the one automated
# cross-check between this comment and the check run was dead code.
blocking="" non_blocking="" pre_existing="" conclusion=""
if [ -s "${CHECK:-}" ]; then
read -r blocking non_blocking pre_existing conclusion < <(jq -r '[(.blocking // "?"),
(.non_blocking // "?"), (.pre_existing // "?"), (.conclusion // "?")] | @tsv' \
read -r blocking non_blocking pre_existing conclusion < <(jq -r '[(.counts.blocking // "?"),
(.counts.non_blocking // "?"), (.counts.pre_existing // "?"), (.conclusion // "?")] | @tsv' \
"$CHECK" 2>/dev/null) || true
fi
if is_count "$blocking" && is_count "$non_blocking"; then
Expand Down
Loading