fix(scenarios/major-upgrade): downward-API env on runner Tasks + tolerate space in gov REST status#351
Merged
Merged
Conversation
… on runner Task containers #350 made taskruntime.LoadWorkflowIdentity mandatory at runner startup so applied SeiNodeTask CRs get a Workflow ownerRef. LoadWorkflowIdentity reads SEI_WORKFLOW_NAME + SEI_NAMESPACE from env (downward API). The keygen/provision-snd/upload-report Task containers already project these via downward API, but the 12 `runner` Task containers in scenarios/major-upgrade.yaml did NOT — pre-#350 the runner didn't need them. Result: every runner step in major-upgrade exits 2 with `seitask: infra: downward-API env not projected: [SEI_WORKFLOW_NAME SEI_NAMESPACE]` before doing any work. The gov pipeline silently failed end-to-end on the first post-#350 fire even though chaos-mesh reported the Workflow Accomplished (because chaos-mesh Accomplished doesn't mean container exit 0). Add the env block to all 12 runner Task containers. scenarios/release-test and scenarios/load-test don't invoke `runner`, so they're unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR SummaryLow Risk Overview This unblocks the major-upgrade scenario after the runner began requiring workflow identity env at startup, preventing runner steps from exiting immediately due to missing env vars. Reviewed by Cursor Bugbot for commit 84aea04. Bugbot is set up for automated code reviews on this repo. Configure here. |
bdchatham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two scenario fixes discovered on the first successful end-to-end major-upgrade fire.
1. Missing downward-API env on runner Task containers
#350madetaskruntime.LoadWorkflowIdentitymandatory at runner startup (readsSEI_WORKFLOW_NAME+SEI_NAMESPACEfrom env via downward API). The 12runnerTask containers inscenarios/major-upgrade.yamlnever had the env block; every runner step exited code 2 withseitask: infra: downward-API env not projected.Added the standard env block to all 12 containers (matching keygen/provision-snd/upload-report).
2. Gov REST response has space after colon
wait-for-proposal-to-passextracts the proposal status with:sed -n 's/.*"status":"\([A-Z_]*\)".*/\1/p'The API returns
"status": "PROPOSAL_STATUS_PASSED"(space after colon). The regex required no space, soSTATUSwas always empty and all 300 polling attempts returned "unknown" — even though the proposal had already passed on-chain (verified by live curl post-mortem).Changed to
[[:space:]]*to tolerate any whitespace.Test plan
SCENARIO_REF+SEITASK_IMAGEto this commit's SHA after ECR buildswait-for-proposal-to-passresolvesPROPOSAL_STATUS_PASSEDand the full upgrade sequence completes🤖 Generated with Claude Code