refactor(create-sei): extract lib and expand test coverage by codebycarson · Pull Request #310 · sei-protocol/sei-js

codebycarson · 2026-03-09T18:33:06Z

This pull request introduces comprehensive Bun-based testing to the create-sei package, replacing the previous Jest setup. It adds both unit and end-to-end (e2e) tests, updates the test and build scripts to use Bun, and improves .gitignore handling for test outputs. The changes also introduce a dedicated tsconfig.json for tests and remove the legacy Jest-based test file.

Testing infrastructure and test coverage:

Added extensive Bun-based unit and integration tests in src/__tests__/lib.test.ts, covering directory name validation, extension listing, project creation, extension overlays, and error handling.
Added Bun-based end-to-end tests in src/__tests__/e2e.test.ts to verify CLI project creation, extension support, dependency installation, and build success.
Introduced a dedicated test tsconfig.json to ensure proper TypeScript settings for tests.
Removed the obsolete Jest-based test file main.test.ts.

Tooling and configuration updates:

Updated package.json to use Bun for testing (bun test), replaced Jest dependencies, and improved build/dev/clean scripts for Bun compatibility. Also added an exports field and public publish config.
Updated .gitignore to ignore Bun test output directories.

changeset-bot · 2026-03-09T18:33:11Z

⚠️ No Changeset found

Latest commit: bc34a1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot

Pull request overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 10 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-09T21:24:56Z

packages/create-sei/src/__tests__/e2e.test.ts

+	test("extension project can install dependencies", async () => {
+		await ensureProject(precompilesProjectName, ["--extension", "precompiles"]);
+		const projectDir = path.join(e2eDir, precompilesProjectName);
+		await installDeps(projectDir);
+	}, 60_000);
+
+	test("extension project can build successfully", async () => {
+		await ensureProject(precompilesProjectName, ["--extension", "precompiles"]);
+		const projectDir = path.join(e2eDir, precompilesProjectName);
+		await installDeps(projectDir);
+
+		const proc = Bun.spawn(["bun", "run", "build"], {
+			cwd: projectDir,


The e2e suite also installs dependencies multiple times for the extension fixture (installDeps is called in both the “can install dependencies” and “can build successfully” tests). Consider reusing the same installed project (or checking for existing node_modules) to reduce runtime.

Copilot · 2026-03-09T21:24:56Z

packages/create-sei/src/lib.ts

+	if (options.name) {
+		if (!isValidDirectoryName(options.name)) {
+			console.log("Invalid package name. Please use a valid npm package name.");
+			valid = false;
+		}


The user-facing message says “Invalid package name. Please use a valid npm package name.”, but isValidDirectoryName currently rejects scoped npm package names (because '/' is illegal in a directory name). Either align the validation to npm package names (allow scopes) or update the message to reflect the actual constraint (directory name / package name without slashes).

Copilot · 2026-03-09T21:24:57Z

packages/create-sei/package.json

+		"build": "tsc -b --force && chmod +x dist/main.js && rsync -av --exclude-from=.rsyncignore ./templates/ ./dist/templates/ && rsync -av --exclude-from=.rsyncignore ./extensions/ ./dist/extensions/",
+		"dev": "tsc --watch",
+		"clean": "rm -rf dist",


The build script no longer clears dist before compiling (tsc -b --force won’t remove outputs for deleted/renamed source files). This can leave stale artifacts under dist/ and potentially ship outdated files. Consider restoring rm -rf dist at the start of build (or tsc -b --clean before build) to ensure a clean output.

Copilot · 2026-03-09T21:24:57Z

packages/create-sei/package.json

 	"scripts": {
-		"build": "rm -rf dist && tsc && chmod +x dist/main.js && rsync -av --exclude-from=.rsyncignore ./templates/ ./dist/templates/ && rsync -av --exclude-from=.rsyncignore ./extensions/ ./dist/extensions/",
-		"dev": "node --loader ts-node/esm src/main.ts",
-		"test": "jest"
+		"build": "tsc -b --force && chmod +x dist/main.js && rsync -av --exclude-from=.rsyncignore ./templates/ ./dist/templates/ && rsync -av --exclude-from=.rsyncignore ./extensions/ ./dist/extensions/",
+		"dev": "tsc --watch",
+		"clean": "rm -rf dist",
+		"test": "bun test"


build/dev scripts rely on tsc, but this package no longer declares typescript in its own devDependencies. If someone runs this package’s scripts outside the monorepo tooling context (or if hoisting changes), these scripts can fail. Consider adding typescript (and any other required tooling) back to devDependencies, or document/enforce that the workspace root provides them.

Copilot · 2026-03-09T21:24:57Z

packages/create-sei/src/__tests__/e2e.test.ts

+	test("generated project can install dependencies", async () => {
+		await ensureProject(baseProjectName);
+		const projectDir = path.join(e2eDir, baseProjectName);
+		await installDeps(projectDir);
+
+		// node_modules should exist
+		const nmExists = await pathExists(path.join(projectDir, "node_modules"));
+		expect(nmExists).toBe(true);
+	}, 60_000);
+
+	test("generated project can build successfully", async () => {
+		await ensureProject(baseProjectName);
+		const projectDir = path.join(e2eDir, baseProjectName);
+		await installDeps(projectDir);
+
+		const proc = Bun.spawn(["bun", "run", "build"], {
+			cwd: projectDir,


The e2e suite runs bun install repeatedly for the same fixture project across multiple tests (e.g., install + build tests both call installDeps). This can significantly slow CI and increase flakiness. Consider installing once per fixture (in beforeAll) or skipping install when node_modules already exists.

Copilot · 2026-03-09T21:24:57Z

packages/create-sei/src/__tests__/e2e.test.ts

+const e2eTmpDirEnv = `${e2eTmpDir}${path.sep}`;
+const e2eSpawnEnv = {
+	...process.env,
+	TMPDIR: e2eTmpDirEnv,
+	BUN_TMPDIR: e2eTmpDirEnv,
+};
+
+async function runCli(
+	args: string[],
+	cwd: string,
+): Promise<{ stdout: string; stderr: string; exitCode: number }> {
+	const proc = Bun.spawn(["node", cliPath, ...args], {
+		cwd,
+		stdout: "pipe",
+		stderr: "pipe",
+		env: { ...process.env, NO_COLOR: "1" },
+	});


e2eSpawnEnv sets TMPDIR/BUN_TMPDIR, but runCli/ensureCliBuilt don’t use it (they build their own env object). If the goal is to keep all subprocess temp output under test-output-e2e/.tmp, consider using e2eSpawnEnv consistently (and layering NO_COLOR on top) so the CLI build/run doesn’t write temp files elsewhere.

Copilot · 2026-03-09T21:24:57Z

packages/create-sei/src/lib.ts

+	// Copy base template
+	const templateName = "next-template";
+	const templatePath = path.join(baseDir, "templates", templateName);
+	const dst = path.join(process.cwd(), dAppName);
+	await fs.promises.cp(templatePath, dst, { recursive: true });


runWizard writes into path.join(process.cwd(), dAppName), which makes tests patch process.cwd globally (see lib.test.ts). Consider adding an explicit destination base directory parameter (e.g., cwd/outputDir) so callers/tests don’t need to mutate global process state.

Copilot · 2026-03-09T21:24:58Z

packages/create-sei/src/__tests__/lib.test.ts

+	test("creates project from base template with --name", async () => {
+		const originalCwd = process.cwd;
+		process.cwd = () => testDir;
+
+		try {
+			await runWizard({ name: "test-app" }, packageDir);
+		} finally {
+			process.cwd = originalCwd;
+		}


These tests temporarily overwrite process.cwd globally to control the output directory. This can become flaky if Bun runs tests concurrently (or if another test relies on process.cwd). Prefer passing an explicit destination directory into runWizard (or using a helper that changes cwd via process.chdir with try/finally) to avoid global mutation.

Copilot · 2026-03-09T21:24:58Z

packages/create-sei/src/__tests__/lib.test.ts

+		const logs: string[] = [];
+		const originalLog = console.log;
+		console.log = (...args: unknown[]) => logs.push(args.join(" "));
+
+		try {
+			await listExtensions(packageDir);
+		} finally {
+			console.log = originalLog;
+		}


console.log is monkey-patched to capture output. If tests execute in parallel, this can interleave logs across tests/files. Consider injecting a logger into listExtensions/runWizard (or using Bun’s spy utilities if available) to avoid mutating global console state.

Copilot · 2026-03-09T21:24:58Z

packages/create-sei/src/main.ts

+	.option(
+		"--name <name>",
+		"Specify the name of your dApp. Name must be a valid package name.",
+	)


The CLI help text says the app name must be a “valid package name”, but the validation rejects scoped npm names because they contain '/'. Consider updating the option description to describe the actual constraint (a directory name / package name without slashes), or adjust validation to truly accept all valid npm package names.

- extract wizard logic into reusable lib module\n- expand unit and e2e coverage for create-sei flows\n- make e2e setup self-contained and auto-build CLI when needed\n- fix test tsconfig inheritance and create-sei build determinism

codebycarson self-assigned this Mar 9, 2026

codebycarson requested a review from Copilot March 9, 2026 19:05

Copilot started reviewing on behalf of codebycarson March 9, 2026 19:06 View session

This comment was marked as resolved.

Sign in to view

codebycarson force-pushed the pr/create-sei-refactor branch 4 times, most recently from 725eceb to e1efb08 Compare March 9, 2026 21:19

codebycarson requested a review from Copilot March 9, 2026 21:19

Copilot started reviewing on behalf of codebycarson March 9, 2026 21:20 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

codebycarson force-pushed the pr/create-sei-refactor branch from e1efb08 to bc34a1f Compare March 9, 2026 21:26

Conversation

codebycarson commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codebycarson commented Mar 9, 2026 •

edited

Loading

changeset-bot bot commented Mar 9, 2026 •

edited

Loading