Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3027 +/- ##
==========================================
+ Coverage 58.27% 58.37% +0.09%
==========================================
Files 2076 2078 +2
Lines 171480 170750 -730
==========================================
- Hits 99933 99670 -263
+ Misses 62615 62182 -433
+ Partials 8932 8898 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-db/state_db/sc/flatkv/store.go
Outdated
|
|
||
| coreCount := runtime.NumCPU() | ||
| readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount)) | ||
| miscPoolSize := int(cfg.MiscPoolThreadsPerCore*float64(coreCount) + float64(cfg.MiscConstantThreadCount)) |
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
sei-db/state_db/sc/flatkv/store.go
Outdated
|
|
||
| coreCount := runtime.NumCPU() | ||
| readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount)) | ||
| miscPoolSize := int(cfg.MiscPoolThreadsPerCore*float64(coreCount) + float64(cfg.MiscConstantThreadCount)) |
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
sei-db/state_db/sc/flatkv/store.go
Outdated
| ctx, cancel := context.WithCancel(ctx) | ||
|
|
||
| coreCount := runtime.NumCPU() | ||
| readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount)) |
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
sei-db/state_db/sc/flatkv/store.go
Outdated
| ctx, cancel := context.WithCancel(ctx) | ||
|
|
||
| coreCount := runtime.NumCPU() | ||
| readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount)) |
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
| "io" | ||
| "os" | ||
| "path/filepath" | ||
| "runtime" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
| valueChan := entry.valueChan | ||
| s.lock.Unlock() | ||
| s.metrics.reportCacheMisses(1) | ||
| startTime := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| entry.valueChan = valueChan | ||
| s.lock.Unlock() | ||
| s.metrics.reportCacheMisses(1) | ||
| startTime := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| } | ||
|
|
||
| s.metrics.reportCacheMisses(int64(len(pending))) | ||
| startTime := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| } | ||
|
|
||
| s.metrics.reportCacheMissLatency(time.Since(startTime)) | ||
| go s.bulkInjectValues(pending) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| missLatency: missLatency, | ||
| } | ||
|
|
||
| go cm.collectLoop(ctx, scrapeInterval, getSize) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
1 participant
Describe your changes and provide context
Add a caching layer to FlatKV, more than doubling performance in cryptosim benchmarks.
Testing performed to validate your change
Unit tests, ran benchmark over several days.